Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Get::html() for all platforms #163

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Implement Get::html() for all platforms #163

merged 9 commits into from
Feb 13, 2025
+92 −24

Conversation

Gae24
Copy link
Contributor

@Gae24 Gae24 commented Oct 12, 2024 •
edited
Loading

I was unable to run tests, since there was a panic on lib.rs:283, but by running the example I was able to confirm it works on windows and linux.
Closes #130 and #157.

@Gae24 Gae24 force-pushed the get-html branch 3 times, most recently from 63f038e to d445228 Compare October 17, 2024 08:34
@Gae24
Copy link
Contributor Author

Gae24 commented Nov 1, 2024

@complexspaces sorry to bother, but what do you think of the changes?

@Gae24 Gae24 mentioned this pull request Jan 2, 2025
Merged
4 tasks
@Fruup
Copy link

Fruup commented Jan 31, 2025 •
edited
Loading

@Gae24 Nice work!

We should also include a method get_html here.

Would also like this to be merged :)

complexspaces
complexspaces requested changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for my tardiness reviewing this, I must have missed the email notification when it came in.

The Windows and Linux implementations look good, but I have a question about the HTML parsing implemented for macOS based on some local testing on macOS 15.3.

src/platform/osx.rs Outdated Show resolved Hide resolved
src/platform/osx.rs Outdated Show resolved Hide resolved
@complexspaces
Copy link
Collaborator

We should also include a method get_html here.

@Fruup Please see my comment in #157 (comment). I would prefer not to add more methods to the top-level Clipboard structure for the time being to keep the API surface smaller.

@complexspaces complexspaces merged commit 4b91bfe into 1Password:master Feb 13, 2025
10 of 11 checks passed
@complexspaces
Copy link
Collaborator

Thank you again for the PR! I quickly fixed the remaining macOS compilation issue to save you some time.

CI is slightly broken but it appears completely unrelated to your changes (and all the important jobs passed), so I went ahead and merged your work.

This was referenced Feb 13, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fruup Fruup Fruup left review comments

@complexspaces complexspaces complexspaces requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gae24 @Fruup @complexspaces